fix: Show feedback form from shake or screenshot without widget#8050
Merged
Conversation
Fix User Feedback shake and screenshot triggers when no managed widget presenter is available by falling back to the active app presenter.
denrase
requested review from
NinjaLikesCheez,
itaybre,
noahsmartin,
philipphofmann and
philprime
as code owners
📲 Install BuildsiOS
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8050 +/- ##
=============================================
+ Coverage 87.401% 87.617% +0.216%
=============================================
Files 559 559
Lines 32170 32174 +4
Branches 13156 13165 +9
=============================================
+ Hits 28117 28190 +73
+ Misses 4004 3937 -67
+ Partials 49 47 -2
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Harness.
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 36c25b3 | 1229.10 ms | 1255.83 ms | 26.73 ms |
| 16c51a6 | 1205.88 ms | 1242.82 ms | 36.94 ms |
| 0a8fa8a | 1230.72 ms | 1261.64 ms | 30.91 ms |
| 69745fc | 1226.70 ms | 1259.72 ms | 33.02 ms |
| 09627e8 | 1223.68 ms | 1261.95 ms | 38.27 ms |
| 1c5ecda | 1219.35 ms | 1253.76 ms | 34.41 ms |
| 7d833a3 | 1226.72 ms | 1263.42 ms | 36.70 ms |
| bc68ff6 | 1227.02 ms | 1254.89 ms | 27.87 ms |
| ba824fc | 1212.75 ms | 1244.29 ms | 31.54 ms |
| 1aa0a18 | 1225.33 ms | 1255.65 ms | 30.31 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 36c25b3 | 24.14 KiB | 1.18 MiB | 1.16 MiB |
| 16c51a6 | 24.14 KiB | 1.17 MiB | 1.15 MiB |
| 0a8fa8a | 24.14 KiB | 1.18 MiB | 1.15 MiB |
| 69745fc | 24.14 KiB | 1.15 MiB | 1.13 MiB |
| 09627e8 | 24.14 KiB | 1.17 MiB | 1.14 MiB |
| 1c5ecda | 24.14 KiB | 1.15 MiB | 1.12 MiB |
| 7d833a3 | 24.14 KiB | 1.16 MiB | 1.13 MiB |
| bc68ff6 | 24.14 KiB | 1.16 MiB | 1.14 MiB |
| ba824fc | 24.14 KiB | 1.17 MiB | 1.15 MiB |
| 1aa0a18 | 24.14 KiB | 1.18 MiB | 1.15 MiB |
philprime
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Fix User Feedback shake and screenshot triggers when no managed widget presenter is available by falling back to the active app presenter.
💡 Motivation and Context
Closes #8023
💚 How did you test it?
Added unit tests.
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.